fix: Error when switching coupon discount type #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victormattosvm
changed the title
victormattosvm
changed the title
victormattosvm
changed the title
kidunot89
requested changes
Feb 2, 2022
There was a problem hiding this comment.
@victormattosvm Sorry about my late response. Can you add this scenario as an assertion here.
kidunot89
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
updateCoupon mutation error
I can't change the coupon discount type from "FIXED PRODUCT" to "PERCENT" or vice versa when the amount is higher than 100 and the amount input is set before the discountType in the mutation.
What does this implement/fix? Explain your changes.
My fix sets the coupon discount type before Woocommerce checks if the amount is valid or not.
Steps to reproduce the issue
1- Create a new coupon with discount type 'FIXED_PRODUCT' and set an amount of 200
2- Change the discount type to 'PERCENT', keeping the same amount. IMPORTANT: put the amount input before the discountType in the mutation.
3. An error will be generated, because when validating the amount, the discount type will still be the old one (PERCENT) and 200 is invalid for percentage.